Lodash to default dependencies#175
Merged
justin808 merged 1 commit intoshakacode:masterfrom Dec 31, 2015
ihnatz:fix-package-json
Merged
Lodash to default dependencies#175justin808 merged 1 commit intoshakacode:masterfrom ihnatz:fix-package-json
justin808 merged 1 commit intoshakacode:masterfrom
ihnatz:fix-package-json
Conversation
Member
|
@robwise How's this look to you? |
Contributor
|
@justin808 If we want to do the bindAll thing in the constructor, then yes this looks good to me. We can completely avoid this dependency and completely eliminate the entire constructor, however, simply by using an alternate method of binding, such as |
justin808
added a commit
that referenced
this pull request
Dec 31, 2015
Lodash to default dependencies
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like we need
lodasheven for version without reduxhttps://github.com/shakacode/react_on_rails/blob/master/lib/generators/react_on_rails/templates/no_redux/base/client/app/bundles/HelloWorld/components/HelloWorldWidget.jsx#L2
Relate to #162