Reviewing files that changed from the base of the PR and between 923525d and dc74d0c.

• CHANGELOG.md (1 hunks)
• node_package/src/clientStartup.ts (1 hunks)
• node_package/src/createReactOutput.ts (1 hunks)
• node_package/src/handleError.ts (1 hunks)
• node_package/src/reactApis.ts (1 hunks)
• node_package/src/reactHydrateOrRender.ts (1 hunks)
• node_package/src/serverRenderReactComponent.ts (1 hunks)
• node_package/src/streamServerRenderedReactComponent.ts (2 hunks)
• node_package/tests/ComponentRegistry.test.js (1 hunks)
• node_package/tests/ReactOnRails.test.js (1 hunks)
• node_package/tests/renderFunction.test.js (1 hunks)
• node_package/tests/serverRenderReactComponent.test.js (1 hunks)
• node_package/tests/streamServerRenderedReactComponent.test.jsx (2 hunks)
• tsconfig.json (1 hunks)

• node_package/src/reactHydrateOrRender.ts
• node_package/src/reactApis.ts
• node_package/src/clientStartup.ts
• node_package/tests/renderFunction.test.js
• node_package/src/serverRenderReactComponent.ts
• node_package/tests/ReactOnRails.test.js
• node_package/src/createReactOutput.ts
• node_package/src/handleError.ts
• node_package/tests/ComponentRegistry.test.js

• GitHub Check: build (newest)
• GitHub Check: rspec-package-tests (newest)
• GitHub Check: build-dummy-app-webpack-test-bundles (oldest)
• GitHub Check: build
• GitHub Check: rspec-package-tests (oldest)

tsconfig.json (1)

4-4: Approval: Disabling esModuleInterop improves library interoperability

This change addresses the core objective of the PR by disabling the esModuleInterop TypeScript compiler option. When a library uses esModuleInterop: true, it forces downstream consumers to adopt the same setting, creating dependency constraints. By setting it to false, you're ensuring that your library will work with a wider range of TypeScript configurations without requiring specific compiler options.

CHANGELOG.md (1)

23-23: Well-documented change in CHANGELOG

The addition to the CHANGELOG is clear and follows the project's conventions. This properly documents the change to disable esModuleInterop and will help users understand what's changed in this version.

node_package/tests/serverRenderReactComponent.test.js (1)

4-4: Import style updated for esModuleInterop compatibility

Changed from default import to namespace import, which is the correct pattern when esModuleInterop is disabled. This ensures the code works with the new TypeScript configuration while maintaining identical functionality.

node_package/tests/streamServerRenderedReactComponent.test.jsx (1)

5-6: Import and component references updated for esModuleInterop compatibility

The imports have been changed from default to namespace imports to align with the disabled esModuleInterop setting. Additionally, the Suspense component now needs to be referenced with the full namespace (React.Suspense) since it's no longer directly imported.

This maintains identical functionality while ensuring compatibility with the updated TypeScript configuration.

Also applies to: 26-28

node_package/src/streamServerRenderedReactComponent.ts (2)

1-1: Import style correctly updated to support disabling esModuleInterop

The import statement has been properly changed from a default import to a namespace import, which aligns with the PR objective of disabling esModuleInterop. This change will improve interoperability with libraries that don't use this TypeScript setting.

---

37-38: Type references correctly updated to use namespace

The type references for PipeableStream have been properly updated to use the namespace syntax (ReactDOMServer.PipeableStream), maintaining type safety while adapting to the new import style. This is the correct approach when switching from named imports to namespace imports.