Remove JsonOutput.escape workaround for Rails < 4.1.1#1580
Merged
Judahmeek merged 4 commits intoshakacode:masterfrom Nov 15, 2023
wwahammy:remove-erb-util-workaround-for-rails-4.1.0
Merged
Remove JsonOutput.escape workaround for Rails < 4.1.1#1580Judahmeek merged 4 commits intoshakacode:masterfrom wwahammy:remove-erb-util-workaround-for-rails-4.1.0
Judahmeek merged 4 commits intoshakacode:masterfrom
wwahammy:remove-erb-util-workaround-for-rails-4.1.0
Conversation
Member
|
@wwahammy Nice catch. How did you find this? |
Contributor
Author
I was curious how the JSON output code worked because I needed something like it for a non-React on Rails project. I just noticed it when I got there. |
Judahmeek
approved these changes
Nov 15, 2023
Contributor
|
@wwahammy thank you for your contribution. |
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 21, 2026
This was referenced Mar 28, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that JsonOutput.escape had a workaround for Rails < 4.1.1. Since the minimum supported Rails version for the gem is greater than that, it doesn't seem like this needs to be there.
Addititionally, I removed the
Utils.rails_version_less_than_4_1_1method since that was the only place it was usedPull Request checklist
Update documentationOther Information
N/A
This change is