Always generate append_X_pack calls if not in development#1545
Merged
Always generate append_X_pack calls if not in development#1545
Conversation
Member
|
@Judahmeek any changelog entry? |
justin808
approved these changes
Jun 14, 2023
Member
justin808
left a comment
justin808
left a comment
There was a problem hiding this comment.
LGTM.
Please add changelog and merge, @Judahmeek
Judahmeek
force-pushed
the
judahmeek/autoload-pack-check
branch
from
585f28e to
acf6e42
Compare
Judahmeek
added a commit
to shakacode/react_on_rails_pro
that referenced
this pull request
Oct 18, 2023
Judahmeek
added a commit
to shakacode/react_on_rails_pro
that referenced
this pull request
Oct 20, 2023
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 25, 2025
Changes to spec/dummy: * Modified tsconfig.json in order to stop webpack recompilation loop * Updated react_on_rails to stop component initialization race condition per [ROR1540](#1540) * Modified prettierignore file to ignore generated packs * Provided render_options to load_pack_for_generated_component per [ROR1545](#1545)
AbanoubGhadban
pushed a commit
that referenced
this pull request
Sep 26, 2025
Changes to spec/dummy: * Modified tsconfig.json in order to stop webpack recompilation loop * Updated react_on_rails to stop component initialization race condition per [ROR1540](#1540) * Modified prettierignore file to ignore generated packs * Provided render_options to load_pack_for_generated_component per [ROR1545](#1545)
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 24, 2026
This was referenced Mar 28, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of creating an
append_X_packcall conditional on the existence of the generated pack entrypoint, the new logic will always create theappend_X_packcall for the component as long as the component's render option'sauto_load_bundleistrueintestorproductionenvironments.In the development environment, however, a missing generated pack entrypoint will result in a raised error message.
Pull Request checklist
Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.
This change is