Skip to content

Remove useless HMR=true from Procfile#1537

Merged
justin808 merged 2 commits intomasterfrom
remove-hmr-env-variable-from-procfile-in-install-template
May 12, 2023
Merged

Remove useless HMR=true from Procfile#1537
justin808 merged 2 commits intomasterfrom
remove-hmr-env-variable-from-procfile-in-install-template

Conversation

@ahangarha
Copy link
Copy Markdown
Contributor

@ahangarha ahangarha commented May 8, 2023

Summary

Remove useless HMR=true from Procfile

Pull Request checklist

Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by ~.

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Other Information

This PR is made based on the discussion with @justin808 on react_on_rails_demo_ssr_hmr upgrade.


This change is Reviewable

@ahangarha ahangarha force-pushed the remove-hmr-env-variable-from-procfile-in-install-template branch from 55e2d3b to 26ccf80 Compare May 8, 2023 22:06
@justin808
Copy link
Copy Markdown
Member

Update the changelog and I'll merge.

@justin808 justin808 merged commit 22980f9 into master May 12, 2023
@justin808 justin808 deleted the remove-hmr-env-variable-from-procfile-in-install-template branch May 12, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants