Fixing wrong type#1480
Merged
justin808 merged 2 commits intoshakacode:masterfrom Sep 22, 2022
Merged
Conversation
The `throwIfMissing` param of `getStore` should be optional as it defaults to `true` https://github.com/shakacode/react_on_rails/blob/35d9d6943f4b52b652c6142a8aa5ef0f8ca36f70/node_package/src/ReactOnRails.ts#L73
Member
|
@wouldntsavezion can you please add an entry to the CHANGELOG.md. Thanks for the submission! |
Judahmeek
approved these changes
Sep 21, 2022
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 24, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
throwIfMissingparam ofgetStoreshould be optional as it defaults totruereact_on_rails/node_package/src/ReactOnRails.ts
Line 73 in 35d9d69
This change is