Skip to content

Include definitions in node package#1287

Merged
justin808 merged 4 commits intomasterfrom
judahmeek/typescript-support
Jun 7, 2020
Merged

Include definitions in node package#1287
justin808 merged 4 commits intomasterfrom
judahmeek/typescript-support

Conversation

@Judahmeek
Copy link
Copy Markdown
Contributor

@Judahmeek Judahmeek commented Jun 6, 2020

DefinitelyTyped recommends including definitions directly in the package when possible, so here are the necessary changes.

I haven't tested consuming these definitions with a new typescript project.

I changed types/index.d.ts to types/index.ts because Typescript's compiler doesn't copy definition files.


This change is Reviewable

Comment thread package.json Outdated
"prepare": "yarn run build",
"prepublish": "npm run prepare",
"build": "yarn run clean && yarn run tsc",
"prepublishOnly": "npm run prepare",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't relevant to typescript, but stops yarn from running yarn build twice after yarn install.

@justin808 justin808 force-pushed the judahmeek/typescript-support branch from 4e7cc1a to 446a900 Compare June 7, 2020 00:17
@justin808 justin808 merged commit e310de8 into master Jun 7, 2020
@justin808 justin808 deleted the judahmeek/typescript-support branch June 7, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants