Skip to content

Fix generator. Do not remove jQuery plugins from application.js#123

Merged
justin808 merged 2 commits intoshakacode:masterfrom
szyablitsky:master
Nov 26, 2015
Merged

Fix generator. Do not remove jQuery plugins from application.js#123
justin808 merged 2 commits intoshakacode:masterfrom
szyablitsky:master

Conversation

@szyablitsky
Copy link
Copy Markdown
Contributor

Fixes #117.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@justin808
Copy link
Copy Markdown
Member

👏 👏 👍

This looks great! Once the CI passe, I'm merging.

Thanks @szyablitsky!

justin808 added a commit that referenced this pull request Nov 26, 2015
Fix generator. Do not remove jQuery plugins from application.js
@justin808 justin808 merged commit 3d71efb into shakacode:master Nov 26, 2015
AbanoubGhadban pushed a commit that referenced this pull request Sep 25, 2025
* and add rails.logger mock to cache_spec
AbanoubGhadban pushed a commit that referenced this pull request Sep 26, 2025
* and add rails.logger mock to cache_spec
justin808 added a commit that referenced this pull request Nov 3, 2025
Fixes identified in code review:

1. PR link format: Changed from `[PR #123]` to `[PR 1818]` (no hash)
   - Analysis shows 165 entries without hash vs only 7 with hash
   - Aligns with actual project standard

2. Added reference to `bundle exec rake update_changelog`
   - This is the existing automation for updating version headers
   - Mentioned in CHANGELOG.md line 18 but was missing from guidelines

3. Verified file ends with newline (required per CLAUDE.md)

These changes ensure guidelines match actual usage and reference
existing automation tools.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
justin808 added a commit that referenced this pull request Nov 3, 2025
* Add changelog guidelines to CLAUDE.md

Following the Shakapacker PR #742 guidelines, this adds comprehensive
changelog documentation requirements to CLAUDE.md:

- Changelog entries required for user-visible changes only (features,
  bug fixes, breaking changes, deprecations, performance improvements)
- No entries needed for linting, formatting, internal refactoring, tests,
  or documentation fixes
- Format requirements: PR links, author links, consistent formatting
- Breaking changes: bold formatting with migration guide links
- Version release: update version diff links

This ensures consistent, high-quality changelog maintenance across
the project.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Fix changelog guidelines: PR format and automation reference

Fixes identified in code review:

1. PR link format: Changed from `[PR #123]` to `[PR 1818]` (no hash)
   - Analysis shows 165 entries without hash vs only 7 with hash
   - Aligns with actual project standard

2. Added reference to `bundle exec rake update_changelog`
   - This is the existing automation for updating version headers
   - Mentioned in CHANGELOG.md line 18 but was missing from guidelines

3. Verified file ends with newline (required per CLAUDE.md)

These changes ensure guidelines match actual usage and reference
existing automation tools.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Enhance changelog guidelines with comprehensive documentation

Following code review recommendations, this adds:

1. **Section header guidance**: Documents both standard keepachangelog.com
   headers (Added, Changed, Deprecated, Removed, Fixed, Security) and
   project-specific headers (Breaking Changes, New Features, Bug Fixes,
   Security Enhancements, API Improvements, etc.)

2. **Complete format examples**: Three real-world examples showing:
   - Simple entry format
   - Breaking change with migration guide
   - Entry with sub-bullets
   All examples verified against actual CHANGELOG.md patterns

3. **Cross-reference**: Added reference to CHANGELOG.md lines 15-18
   for contributor guidelines and keepachangelog.com format

4. **Better organization**: Restructured into subsections (Section Headers,
   Format Requirements, Entry Format Examples) for easier reference

These enhancements make the guidelines actionable and ensure consistent,
high-quality changelog entries.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Simplify changelog section to conserve space

Reduces the changelog section from ~50 lines to 5 concise bullets:
- Consolidates what to include/exclude into one line each
- Provides format example inline instead of separate section
- References CHANGELOG.md lines 15-18 for full guidelines
- Points to existing `bundle exec rake update_changelog` task
- Includes grep command to view real formatting examples

This saves space while making the guidelines more actionable by
pointing developers to existing tools and real examples rather
than duplicating information.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Add /update-changelog command for guided changelog updates

Adds comprehensive slash command based on Shakapacker's implementation
with React on Rails-specific improvements:

**New slash command**: `/update-changelog`
- Provides guided workflow for adding changelog entries
- Ensures correct formatting (no hash in PR numbers)
- Validates user-visible vs non-user-visible changes
- Handles version boundaries and beta releases
- Includes real examples from the codebase
- Documents both standard and custom section headers

**Improvements over Shakapacker version**:
- Updated PR link format (no hash symbol)
- Documents all React on Rails custom section headers
- References `bundle exec rake update_changelog` for version management
- Includes actual examples from CHANGELOG.md
- Added grep command for viewing real formatting examples

**Updated CLAUDE.md**:
- References `/update-changelog` command for guided updates
- Separates version management (rake task) from entry creation (command)
- Maintains concise 6-bullet format

This makes changelog updates consistent and reduces errors by providing
an interactive guided process with comprehensive documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Fix update-changelog command: remove redundancy and fix formatting

Addresses code review feedback:

1. **Removed redundant section headers**:
   - "New Features" (redundant with standard "Added")
   - "Bug Fixes" (redundant with standard "Fixed")
   - "Security Enhancements" (redundant with standard "Security")
   - "Code Improvements" (internal, not user-visible)

2. **Added "Improved" to standard headers** (used 9 times in CHANGELOG.md)

3. **Emphasized standard headers**: Updated guidance to prefer standard
   keepachangelog.com headers and use custom ones sparingly

4. **Fixed broken markdown formatting**:
   - Corrected triple/quadruple backtick issues in Breaking Change example
   - Removed nested code blocks that broke rendering
   - Simplified code examples within the markdown example

5. **Final header list**:
   - Standard: Added, Changed, Deprecated, Removed, Fixed, Security, Improved
   - Custom: Breaking Changes, API Improvements, Developer Experience,
     Generator Improvements, Performance, Pro License Features

This reduces confusion and ensures the command guides developers to use
consistent, standard headers while keeping legitimate project-specific
headers for special cases.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants