Add method for retrieving any option from render_options or nil instead#1213
Merged
Add method for retrieving any option from render_options or nil instead#1213
Conversation
f2b65ca to
620355b
Compare
justin808
requested changes
May 3, 2019
Member
justin808
left a comment
There was a problem hiding this comment.
Small changes requested.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashgaliyev)
CHANGELOG.md, line 17 at r1 (raw file):
Changes since last non-beta release. - Added method for retrieving any option from `render_options` [PR 1213](https://github.com/shakacode/react_on_rails/pull/1213)
- add by name
- put in 11.3.0 and update date for it 😄
lib/react_on_rails/react_component/render_options.rb, line 75 at r1 (raw file):
end def option(key)
def internal_option(key)
options[key]
end
justin808
reviewed
May 6, 2019
Member
justin808
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashgaliyev)
3 tasks
This was referenced Mar 8, 2026
This was referenced Mar 15, 2026
This was referenced Mar 24, 2026
This was referenced Apr 18, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is