Skip to content

Server Side rendering disabled if HMR running#1156

Merged
justin808 merged 2 commits intomasterfrom
justin808/disable-server-rendering-if-hmr
Oct 14, 2018
Merged

Server Side rendering disabled if HMR running#1156
justin808 merged 2 commits intomasterfrom
justin808/disable-server-rendering-if-hmr

Conversation

@justin808
Copy link
Copy Markdown
Member

@justin808 justin808 commented Oct 14, 2018

Reasonable to skip server rendering when HMR is turned on.


This change is Reviewable

Reasonable to skip server rendering when HMR is turned on.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at ?% when pulling 4665e66 on justin808/disable-server-rendering-if-hmr into 28c6187 on master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 14, 2018

Coverage Status

Coverage remained the same at ?% when pulling f70f765 on justin808/disable-server-rendering-if-hmr into 28c6187 on master.

@justin808 justin808 merged commit 782e5c7 into master Oct 14, 2018
@justin808 justin808 deleted the justin808/disable-server-rendering-if-hmr branch October 14, 2018 22:34
Copy link
Copy Markdown
Contributor

@coopersamuel coopersamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 so essentially this PR disables server rendering when developing with HMR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants