Work on babel 7 with transform-runtime#1140
Conversation
…ils to work with babel@7 (shakacode#1136)" This reverts commit de06717. In general, Webpack doesn't build under `node_modules`. So react-on-rails should support browser compatible build.
babel-runtime is not installed Babel 7 environment. (Babel 7 denpends @babel/runtime.) So this should be depended as "dependencies".
justin808
left a comment
justin808
left a comment
There was a problem hiding this comment.
Should we upgrade the whole project to babel 7 with this?
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tricknotes)
package.json, line 15 at r1 (raw file):
https://github.com/shakacode/react_on_rails/pull/11
package.json, line 15 at r1 (raw file):
|
Thanks for your review, @justin808 !
It doesn't depend on this change. And I'm sorry not to see your review comment from reviewable.io. (It seems leaving empty :<) Could you tell me what you want to comment? |
Ah, I misunderstood that you mean upgrading to babel 7 of react-on-rails. The answer is no. |
|
@tricknotes Thanks! Yes, let's update the project for Babel 7: the spec/dummy app, and other package.json files. I agree, definitely don't require this upgrade. Once we get that done, I'll cut a release. |
|
@justin808 |
3 participants
Previously, I sent a PR to stop using babel-plugin-transform-runtime. #1136
But this breaks build for legacy browser.
So I fixed to apply babel-plugin-transform-runtime.
And it is allow to use for Babel 7 users by providing babel-runtime as "dependencies".
This change is