Conversation
3163d84 to
95e319c
Compare
|
Lots of better names... Review status: 0 of 11 files reviewed at latest revision, all discussions resolved, some commit checks broke. lib/react_on_rails/react_on_rails_helper.rb, line 101 at r1 (raw file):
options is for a plain Hash renderer_options is for our special object of configuration when rendering Comments from Reviewable |
- `react_component` allows logging_on_server specified at the component level. - Missing class when throwing some error messages.
95e319c to
e224450
Compare
|
@mapreal19 Still review. |
|
Reviewed 9 of 15 files at r1, 2 of 4 files at r2. lib/react_on_rails/react_on_rails_helper.rb, line 435 at r2 (raw file):
I'd remove this comment. The reader can see we're raising a prerender error anyway lib/react_on_rails/server_rendering_pool/ruby_embedded_java_script.rb, line 62 at r2 (raw file):
we should leave private here? Comments from Reviewable |
This change is