Skip to content

Added 2 helpers to get hashed file names#1018

Merged
justin808 merged 1 commit intomasterfrom
add-bundle-name-helpers
Jan 24, 2018
Merged

Added 2 helpers to get hashed file names#1018
justin808 merged 1 commit intomasterfrom
add-bundle-name-helpers

Conversation

@justin808
Copy link
Copy Markdown
Member

@justin808 justin808 commented Jan 24, 2018

Added 2 cache helpers:

ReactOnRails::Utils.bundle_file_name(bundle_name)
ReactOnRails::Utils.server_bundle_file_name

for easy access to the hashed filenames for use in cache keys


This change is Reviewable

@robwise
Copy link
Copy Markdown
Contributor

robwise commented Jan 24, 2018

:lgtm:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 24, 2018

Coverage Status

Coverage remained the same at ?% when pulling 32c6fd6 on add-bundle-name-helpers into 8c8077b on master.

Added 2 cache helpers:

ReactOnRails::Utils.bundle_file_name(bundle_name)
ReactOnRails::Utils.server_bundle_file_name

for easy access to the hashed filenames for use in cache keys
@justin808 justin808 force-pushed the add-bundle-name-helpers branch from bf45eee to 32c6fd6 Compare January 24, 2018 05:36
@justin808 justin808 merged commit 99e0341 into master Jan 24, 2018
@justin808 justin808 deleted the add-bundle-name-helpers branch January 24, 2018 05:53
justin808 added a commit that referenced this pull request Jan 24, 2018
Added 2 cache helpers:

ReactOnRails::Utils.bundle_file_name(bundle_name)
ReactOnRails::Utils.server_bundle_file_name

for easy access to the hashed filenames for use in cache keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants