Use redux in generated hello world example#1006
Use redux in generated hello world example#1006lewaabahmad wants to merge 2 commits intoshakacode:masterfrom lewaabahmad:use-redux-in-generated-hello-world-example
Conversation
|
Thanks! Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. .gitignore, line 36 at r1 (raw file):
this probably doesn't need to be part of the of the .gitignore Comments from Reviewable |
|
Let's remove the .gitignore change and I'll merge and publish a new version. Reviewed 3 of 3 files at r1. Comments from Reviewable |
|
@lewaabahmad please ping me when you remove the .gitignore changes. Or let me know why they are needed. |
|
@lewaabahmad Can you please let me know about the .gitignore change? |
2 similar comments
|
@lewaabahmad Can you please let me know about the .gitignore change? |
|
@lewaabahmad Can you please let me know about the .gitignore change? |
|
See PR #1019 |
|
@justin808 Sorry!!! I really didn't see those notifications! Was just checking the issue and saw it was merged. I added those because of Vim! Vim creates those files to make edits! Again, my most sincere apologies! Glad this was good! 👍 |
This change is