Summary
railsContext.rorPro can be read as "has valid Pro license", but in current implementation it means "Pro gem/package is installed".
That distinction is important when reasoning about licensing behavior in browser code and docs.
Evidence
- Rails context sets:
react_on_rails/lib/react_on_rails/helper.rb
rorPro: ReactOnRails::Utils.react_on_rails_pro?
react_on_rails_pro? checks gem availability (not license validity):
react_on_rails/lib/react_on_rails/utils.rb
- comment explicitly says: "Note: This only checks gem presence, not license validity"
- Client code variable naming suggests license meaning:
packages/react-on-rails-pro/src/ClientSideRenderer.ts
const hasProLicense = railsContext.rorPro;
Proposed fix
At minimum: documentation/comments clarification that rorPro is a Pro-install signal, not JWT validation status.
Optional small cleanup: rename local client variable(s) like hasProLicense to hasProInstalled for clarity (no API change).
Acceptance criteria
- Docs/comments unambiguously define
rorPro semantics.
- (Optional) Internal variable names avoid license-valid implication.
Summary
railsContext.rorProcan be read as "has valid Pro license", but in current implementation it means "Pro gem/package is installed".That distinction is important when reasoning about licensing behavior in browser code and docs.
Evidence
react_on_rails/lib/react_on_rails/helper.rbrorPro: ReactOnRails::Utils.react_on_rails_pro?react_on_rails_pro?checks gem availability (not license validity):react_on_rails/lib/react_on_rails/utils.rbpackages/react-on-rails-pro/src/ClientSideRenderer.tsconst hasProLicense = railsContext.rorPro;Proposed fix
At minimum: documentation/comments clarification that
rorProis a Pro-install signal, not JWT validation status.Optional small cleanup: rename local client variable(s) like
hasProLicensetohasProInstalledfor clarity (no API change).Acceptance criteria
rorProsemantics.