-
-
Notifications
You must be signed in to change notification settings - Fork 633
Comparing changes
Open a pull request
base repository: shakacode/react_on_rails
base: 6.2.1
head repository: shakacode/react_on_rails
compare: 6.3.0
- 10 commits
- 54 files changed
- 6 contributors
Commits on Nov 23, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3cde086 - Browse repository at this point
Copy the full SHA 3cde086View commit details
Commits on Nov 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 03c5e96 - Browse repository at this point
Copy the full SHA 03c5e96View commit details
Commits on Nov 30, 2016
-
Remove section on lib/tasks/asset.rake (#627)
Addresses Issue #616. React on Rails has been updated so this is no longer needed.
Configuration menu - View commit details
-
Copy full SHA for 17512b1 - Browse repository at this point
Copy the full SHA 17512b1View commit details -
Update Basic Generator & Linters (#624)
* Update basic generator so that the basic example is simpler * All files registered for react on rails go in the registration.js file.
Configuration menu - View commit details
-
Copy full SHA for 48d1747 - Browse repository at this point
Copy the full SHA 48d1747View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae9785b - Browse repository at this point
Copy the full SHA ae9785bView commit details -
Don't assume ActionMailer is available (#608)
If the Rails app that uses this gem doesn't include the ActionMailer railtie, the gem raises this error: `uninitialized constant ReactOnRailsHelper::ActionMailer` This change introduces a check that the ActionMailer constant is defined before setting the 'inMailer' option. I'm not quite sure how to test this, so if anyone has ideas, that would be helpful.
Configuration menu - View commit details
-
Copy full SHA for 2a227d4 - Browse repository at this point
Copy the full SHA 2a227d4View commit details
Commits on Dec 1, 2016
-
Modify register API to accept renderer functions (#581)
Made the following changes to the node package: * ComponentRegistry.js: Modified register to detect generator functions with three arguments. Set the isRenderer key to true for these functions. * clientStartup.js: Added logic to delegate to renderer functions. * createReactElement.js: Now accepts an object instead of a component name. * serverRenderReactComponent.js: Throws an error if attempting to render a renderer function. * ReactOnRails.js: Change render function to call createReactElement with the component object. Doc changes: * README.md: Added section about renderer function under the section on generator functions. Moved the section on generator functions from the 'ReactOnRails View Helpers API' section to the 'Globally Exposing Your React Components' section. * Added a file code-splitting.md that describes how to use renderer functions to do code splitting with server rendering. Tests: * ComponentRegistry.test.js: Modified existing test cases to expect the isRenderer key to be false. Added a few test cases related to renderer functions. * serverRenderReactComponent.test.js: Show that an error gets thrown if trying to server render with a renderer function. * spec/dummy: Added two examples using rendering functions, one of which implements code splitting. Added three test to integration_spec.rb. Resolves: #477
Configuration menu - View commit details
-
Copy full SHA for 62fb5d6 - Browse repository at this point
Copy the full SHA 62fb5d6View commit details -
Slight improvement to the 'no hydrated stores' error (#605)
* Slight improvement to the 'no hydrated stores' error This should make it more clear that rendering `redux_store_hydration_data` is required. This should more cleanly differentiate the two cases * Change hydrated stores error to be a list of actions
Configuration menu - View commit details
-
Copy full SHA for 843c43d - Browse repository at this point
Copy the full SHA 843c43dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 699fd59 - Browse repository at this point
Copy the full SHA 699fd59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ca22d3 - Browse repository at this point
Copy the full SHA 7ca22d3View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 6.2.1...6.3.0