Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: shakacode/react_on_rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.1.0
Choose a base ref
...
head repository: shakacode/react_on_rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.1.1
Choose a head ref
  • 9 commits
  • 25 files changed
  • 5 contributors

Commits on Aug 22, 2016

  1. Configuration menu
    Copy the full SHA
    948697c View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2016

  1. Merge pull request #531 from AlexKVal/npm-scripts

    Clean up a bit of npm scripts
    justin808 authored Aug 23, 2016
    Configuration menu
    Copy the full SHA
    ffcf0c8 View commit details
    Browse the repository at this point in the history
  2. Add Flowtype (WIP) (#530)

    * Add 'flowtype' checking to 'node_package' folder
    * Enable flowtype for Authenticity.js
    * Enable flowtype for buildConsoleReplay.js
    * Enable flowtype for generatorFunction.js
    AlexKVal authored and justin808 committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    f0058d4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2016

  1. Integrate with Gitbook (#534)

    Judahmeek authored and justin808 committed Aug 28, 2016
    Configuration menu
    Copy the full SHA
    37712ee View commit details
    Browse the repository at this point in the history
  2. Fix Gitbook links (#535)

    Judahmeek authored and justin808 committed Aug 28, 2016
    Configuration menu
    Copy the full SHA
    3990447 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2016

  1. update gem version suggested in README (#536)

    the README instructs the user to install v5 of the the gem, but v6 is already available. When I followed the readme, I was very surprised when I ran npm upgrade and immediately got a new version of the npm package, which made me wonder if I was missing updates in the ruby gem as well.
    Aeon authored and justin808 committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    ebf079b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2016

  1. Fix symlink regression (#541)

    Fix AssetsPrecompile#symlink_file logic
    
    When we changed this method in #513 we introduced a regression due
    to the difference between calling the shell's `ln -s` command and
    using Ruby's `File.symlink` command.
    
    Specifically, the former would not error if the symlink already
    existed, while the latter did throw an error. Because it is
    sometimes the case that the symlink will already exist, throwing
    in this case is not desirable.
    
    This should have not been a problem, however, as this scenario
    was supposed to have been properly handled, but that code was not
    correct. This commit fixes that code.
    
    * Allow filtering react_on_rails specs with :focus
    * Fix possible open resource leak in AssetsPrecompile spec
    robwise authored and justin808 committed Sep 10, 2016
    Configuration menu
    Copy the full SHA
    211fed0 View commit details
    Browse the repository at this point in the history
  2. Updated CHANGELOG.md

    justin808 committed Sep 10, 2016
    Configuration menu
    Copy the full SHA
    024e00d View commit details
    Browse the repository at this point in the history
  3. Release 6.1.1

    justin808 committed Sep 10, 2016
    Configuration menu
    Copy the full SHA
    1d1eea2 View commit details
    Browse the repository at this point in the history
Loading