Remove dead SystemChecker wildcard methods and tests

cursoragent · cursoragent · commit e5fd6d703212 · 2026-04-05T05:11:49.000Z
diff --git a/react_on_rails/lib/react_on_rails/system_checker.rb b/react_on_rails/lib/react_on_rails/system_checker.rb
@@ -736,58 +736,6 @@ def report_dependency_status(required_deps, missing_deps, package_json)
       MSG
     end
 
-    def check_version_patterns(npm_version, _gem_version)
-      # Check for version range patterns in package.json
-      return unless /^[\^~><*]/.match?(npm_version) || npm_version.include?(" ")
-
-      add_error(<<~MSG.strip)
-        🚫 NPM package uses a non-exact version: #{npm_version}
-
-        React on Rails requires exact version matching. Non-exact constraints will
-        cause a runtime error on app startup.
-
-        Fix: bundle exec rake react_on_rails:sync_versions WRITE=true
-      MSG
-    end
-
-    def check_gemfile_version_patterns
-      gemfile_path = ENV["BUNDLE_GEMFILE"] || "Gemfile"
-      return unless File.exist?(gemfile_path)
-
-      begin
-        gemfile_content = File.read(gemfile_path)
-        check_gemfile_version_pattern_for(gemfile_content, "react_on_rails")
-        if ReactOnRails::Utils.react_on_rails_pro?
-          check_gemfile_version_pattern_for(gemfile_content,
-                                            "react_on_rails_pro")
-        end
-      rescue StandardError
-        # Ignore errors reading Gemfile
-      end
-    end
-
-    def check_gemfile_version_pattern_for(gemfile_content, gem_name)
-      gem_line = gemfile_content.lines.find { |line| line.match(/^\s*gem\s+['"]#{gem_name}['"]/) }
-      return unless gem_line
-
-      return unless /['"][~^]/.match?(gem_line) || />=\s*/.match?(gem_line)
-
-      version = if gem_name == "react_on_rails_pro"
-                  ReactOnRails::Utils.react_on_rails_pro_version
-                else
-                  ReactOnRails::VERSION
-                end
-      add_error(<<~MSG.strip)
-        🚫 Gemfile uses a non-exact version constraint for #{gem_name}.
-
-        React on Rails requires exact version matching between the gem and npm package.
-        Non-exact constraints can cause versions to drift apart, leading to runtime errors.
-
-        Fix: Use an exact version in your Gemfile:
-          gem '#{gem_name}', '#{version}'
-      MSG
-    end
-
     def report_dependency_versions(package_json)
       all_deps = (package_json["dependencies"] || {}).merge(package_json["devDependencies"] || {})
 
diff --git a/react_on_rails/spec/lib/react_on_rails/system_checker_spec.rb b/react_on_rails/spec/lib/react_on_rails/system_checker_spec.rb
@@ -220,72 +220,6 @@
     end
   end
 
-  describe "#check_version_patterns" do
-    it "errors on caret version patterns" do
-      checker.send(:check_version_patterns, "^16.0.0", "16.0.0")
-      expect(checker.errors?).to be true
-      expect(checker.messages.last[:content]).to include("non-exact version")
-    end
-
-    it "errors on tilde version patterns" do
-      checker.send(:check_version_patterns, "~16.0.0", "16.0.0")
-      expect(checker.errors?).to be true
-      expect(checker.messages.last[:content]).to include("non-exact version")
-    end
-
-    it "does not warn about exact versions" do
-      initial_message_count = checker.messages.count
-      checker.send(:check_version_patterns, "16.0.0", "16.0.0")
-      expect(checker.messages.count).to eq(initial_message_count)
-    end
-  end
-
-  describe "#check_gemfile_version_patterns" do
-    context "when Gemfile has version patterns" do
-      let(:gemfile_content) do
-        <<~GEMFILE
-          gem 'rails', '~> 7.0'
-          gem 'react_on_rails', '~> 16.0'
-          gem 'other_gem'
-        GEMFILE
-      end
-
-      before do
-        gemfile_path = ENV["BUNDLE_GEMFILE"] || "Gemfile"
-        allow(File).to receive(:exist?).with(gemfile_path).and_return(true)
-        allow(File).to receive(:read).with(gemfile_path).and_return(gemfile_content)
-        stub_const("ReactOnRails::VERSION", "16.0.0")
-      end
-
-      it "errors on non-exact version patterns" do
-        checker.send(:check_gemfile_version_patterns)
-        expect(checker.errors?).to be true
-        expect(checker.messages.last[:content]).to include("non-exact version constraint")
-      end
-    end
-
-    context "when Gemfile has exact versions" do
-      let(:gemfile_content) do
-        <<~GEMFILE
-          gem 'rails', '7.0.0'
-          gem 'react_on_rails', '16.0.0'
-        GEMFILE
-      end
-
-      before do
-        gemfile_path = ENV["BUNDLE_GEMFILE"] || "Gemfile"
-        allow(File).to receive(:exist?).with(gemfile_path).and_return(true)
-        allow(File).to receive(:read).with(gemfile_path).and_return(gemfile_content)
-      end
-
-      it "does not warn about exact versions" do
-        initial_message_count = checker.messages.count
-        checker.send(:check_gemfile_version_patterns)
-        expect(checker.messages.count).to eq(initial_message_count)
-      end
-    end
-  end
-
   describe "#check_react_on_rails_npm_package" do
     context "when package.json exists with react-on-rails" do
       let(:package_json_content) do
