Fix generator inheriting BUNDLE_GEMFILE from parent process

ihabadham · claude · ihabadham · commit d4f7d8ede6e1 · 2026-01-09T20:30:36.000+02:00
Wrap bundler commands in install_generator.rb with Bundler.with_unbundled_env to prevent BUNDLE_GEMFILE inheritance from the parent process. This fixes "injected gems" conflicts when running `bundle exec rails g react_on_rails:install`. The issue occurs because system() calls inherit the parent's BUNDLE_GEMFILE environment variable, causing bundler to use the wrong Gemfile when the generator runs bundle commands. This is a well-documented Bundler issue (rubygems/bundler#698, rails/rails#3153) and the fix follows the official solution recommended by Bundler maintainers since 2012. Fixes #2287 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
diff --git a/react_on_rails/lib/generators/react_on_rails/install_generator.rb b/react_on_rails/lib/generators/react_on_rails/install_generator.rb
@@ -263,7 +263,7 @@ def ensure_shakapacker_in_gemfile
         return if shakapacker_in_gemfile?
 
         puts Rainbow("📝 Adding Shakapacker to Gemfile...").yellow
-        success = system("bundle add shakapacker --strict")
+        success = Bundler.with_unbundled_env { system("bundle add shakapacker --strict") }
         return if success
 
         handle_shakapacker_gemfile_error
@@ -274,14 +274,14 @@ def install_shakapacker
 
         # First run bundle install to make shakapacker available
         puts Rainbow("📦 Running bundle install...").yellow
-        bundle_success = system("bundle install")
+        bundle_success = Bundler.with_unbundled_env { system("bundle install") }
         unless bundle_success
           handle_shakapacker_install_error
           return
         end
 
         # Then run the shakapacker installer
-        success = system("bundle exec rails shakapacker:install")
+        success = Bundler.with_unbundled_env { system("bundle exec rails shakapacker:install") }
         return if success
 
         handle_shakapacker_install_error
