Fix add_npm_dependencies success return semantics

cursoragent · cursoragent · commit c269e17ff730 · 2026-03-24T06:35:22.000Z
diff --git a/react_on_rails/lib/generators/react_on_rails/generator_helper.rb b/react_on_rails/lib/generators/react_on_rails/generator_helper.rb
@@ -26,12 +26,12 @@ def add_npm_dependencies(packages, dev: false)
     return false unless pj
 
     begin
-      result = if dev
-                 pj.manager.add(packages, type: :dev, exact: true)
-               else
-                 pj.manager.add(packages, exact: true)
-               end
-      result ? true : false
+      if dev
+        pj.manager.add(packages, type: :dev, exact: true)
+      else
+        pj.manager.add(packages, exact: true)
+      end
+      true
     rescue StandardError => e
       say_status :warning, "Could not add packages via package_json gem: #{e.message}", :yellow
       say_status :warning, "Will fall back to direct npm commands.", :yellow
