Fix redux install success banner on incomplete setup

cursoragent · cursoragent · commit 96e6670af66f · 2026-03-15T10:14:59.000Z
diff --git a/react_on_rails/lib/generators/react_on_rails/install_generator.rb b/react_on_rails/lib/generators/react_on_rails/install_generator.rb
@@ -102,9 +102,7 @@ def run_generators
         if installation_prerequisites_met? || options.ignore_warnings?
           invoke_generators
           add_bin_scripts
-          # Only add the post install message if not using Redux
-          # Redux generator handles its own messages
-          add_post_install_message unless options.redux?
+          add_post_install_message
         else
           error = <<~MSG.strip
             🚫 React on Rails generator prerequisites not met!
diff --git a/react_on_rails/lib/generators/react_on_rails/react_with_redux_generator.rb b/react_on_rails/lib/generators/react_on_rails/react_with_redux_generator.rb
@@ -90,10 +90,7 @@ def add_redux_npm_dependencies
       end
 
       def add_redux_specific_messages
-        # Append Redux-specific post-install instructions
-        GeneratorMessages.add_info(
-          GeneratorMessages.helpful_message_after_installation(component_name: "HelloWorldApp", route: "hello_world")
-        )
+        # InstallGenerator handles post-install messaging for all install modes.
       end
 
       private
diff --git a/react_on_rails/spec/react_on_rails/generators/install_generator_spec.rb b/react_on_rails/spec/react_on_rails/generators/install_generator_spec.rb
@@ -1673,6 +1673,24 @@ class ActiveSupport::TestCase
       expect(output_text).not_to include("🎉 React on Rails Successfully Installed!")
       expect(output_text).not_to include("📋 QUICK START:")
     end
+
+    specify "shows incomplete-installation guidance for redux installs when shakapacker setup fails" do
+      install_generator = described_class.new([], { redux: true, ignore_warnings: true })
+      allow(install_generator).to receive(:installation_prerequisites_met?).and_return(true)
+      allow(install_generator).to receive(:invoke_generators) do
+        install_generator.instance_variable_set(:@shakapacker_setup_incomplete, true)
+      end
+      allow(install_generator).to receive(:add_bin_scripts)
+      allow(install_generator).to receive(:print_generator_messages)
+
+      install_generator.run_generators
+      output_text = GeneratorMessages.output.join("\n")
+
+      expect(output_text).to include("React on Rails installation is incomplete")
+      expect(output_text).to include("Avoid running ./bin/dev")
+      expect(output_text).not_to include("🎉 React on Rails Successfully Installed!")
+      expect(output_text).not_to include("📋 QUICK START:")
+    end
   end
 
   describe "--pretend mode behavior" do
