Skip renderer kill fallback for remote URLs

justin808 · justin808 · commit 5ef6d502429a · 2026-05-04T00:29:56.000-10:00
diff --git a/react_on_rails/lib/react_on_rails/dev/server_manager.rb b/react_on_rails/lib/react_on_rails/dev/server_manager.rb
@@ -77,17 +77,28 @@ def killable_ports
 
         def default_killable_ports
           ports = [3000, 3001]
-          ports << configured_renderer_port_for_kill if pro_renderer_active?
+          if pro_renderer_active?
+            renderer_port = configured_renderer_port_for_kill
+            ports << renderer_port if renderer_port
+          end
           ports
         end
 
         def configured_renderer_port_for_kill
           raw_port = ENV.fetch("RENDERER_PORT", nil)
           return raw_port.strip.to_i if valid_port_string?(raw_port)
+          return nil if remote_renderer_url_configured?
 
           3800
         end
 
+        def remote_renderer_url_configured?
+          %w[REACT_RENDERER_URL RENDERER_URL].any? do |var|
+            url = ENV.fetch(var, nil)
+            !url.nil? && !url.strip.empty? && !localhost_renderer_url?(url)
+          end
+        end
+
         def development_processes
           {
             "rails" => "Rails server",
diff --git a/react_on_rails/spec/react_on_rails/dev/server_manager_spec.rb b/react_on_rails/spec/react_on_rails/dev/server_manager_spec.rb
@@ -1214,6 +1214,19 @@ def mock_port_selector_defaults
 
       described_class.kill_processes
     end
+
+    it "does not target the default renderer port for a remote renderer URL" do
+      ENV["REACT_RENDERER_URL"] = "https://renderer.internal:3800"
+      allow(ReactOnRails::Dev::PortSelector).to receive(:base_port_hash).and_return(nil)
+      # No pattern-based processes so kill_port_processes runs.
+      allow(Open3).to receive(:capture2).with("pgrep", any_args).and_return(["", nil])
+
+      allow(Open3).to receive(:capture2).with("lsof", "-ti", ":3000", err: File::NULL).and_return(["", nil])
+      allow(Open3).to receive(:capture2).with("lsof", "-ti", ":3001", err: File::NULL).and_return(["", nil])
+      expect(Open3).not_to receive(:capture2).with("lsof", "-ti", ":3800", err: File::NULL)
+
+      described_class.kill_processes
+    end
   end
 
   describe ".find_port_pids" do
