Skip to content

Conversation

@Mygod
Copy link
Collaborator

@Mygod Mygod commented Feb 4, 2020

@Mygod Mygod requested a review from madeye February 4, 2020 01:52
@CzBiX
Copy link

CzBiX commented Feb 4, 2020

应该用 v2ray-plugin 当 id,v2ray 当 alias?
不然导出的时候还会是 v2ray,没法在其他平台使用了。

@Mygod
Copy link
Collaborator Author

Mygod commented Feb 4, 2020

shadowsocks-android will respect whichever is imported when exporting.

@CzBiX
Copy link

CzBiX commented Feb 4, 2020

我是指用户在手机上编辑配置文件,选择了 v2ray 插件,然后导出的情况。

@Mygod Mygod marked this pull request as ready for review February 5, 2020 04:40
@Mygod
Copy link
Collaborator Author

Mygod commented Feb 5, 2020

@CzBiX Accepted considering the file naming in shadowsocks/v2ray-plugin.

@Mygod Mygod changed the title Add alias v2ray-plugin Change ID to v2ray-plugin with back compatibility Feb 5, 2020
@Mygod
Copy link
Collaborator Author

Mygod commented Feb 7, 2020

@madeye Testing this change shouldn't require an update for plugin library. :)

@madeye
Copy link
Collaborator

madeye commented Feb 7, 2020

The new plugin has been released..

I guess the problem is the go version. I also updated the v2ray-plugin, which depends on go 1.13.

@madeye madeye merged commit cde826b into master Feb 7, 2020
@Mygod Mygod deleted the plugin-1.3.4 branch February 7, 2020 07:57
@Mygod
Copy link
Collaborator Author

Mygod commented Feb 7, 2020

We should release the main app first otherwise the alias thing will not be migrated smoothly.

@madeye
Copy link
Collaborator

madeye commented Feb 7, 2020

Sure, I'll release the shadowsocks app first.

@Mygod
Copy link
Collaborator Author

Mygod commented Feb 7, 2020

Done fixing some issues in v5.0.3 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change plugin id from 'v2ray' to 'v2ray-plugin' for consistency

4 participants