-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
fix implicit-function-declaration error when updating NDK to r26+ #3163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi thanks but this does not seem to work properly: |
|
It works in a release build. Actually, the function In a debug build, if no changes in A solution is removing the function |
|
What a day! |
|
Ideally debug should be built too. :) |
|
If there is not a clang flag to turn this error off, I can make a pull request to |
|
Hmm libevent hasn't been updated in a while. Maybe pulling upstream is needed. |
|
Made a pull request at shadowsocks/libevent#3 |
|
Does that fix this? |
|
Yes. The After that libevent pull request is merged, I will add a commit to this pull request to update submodule and Android.mk. |
|
Ready to merge. |
https://github.com/android/ndk/wiki/Changelog-r26#changes
Since NDK r26, Clang now treats -Wimplicit-function-declaration as an error rather than a warning in C11 and newer.
In the submodules, function
pipe2inredsocks.cfromredsocksand functionarc4random_addrandominevutil_rand.cfromlibeventare implicitly declared.