src/chsh.c: add argument for fail_exit() #1414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerexxe
force-pushed
the
fix-fail-exit
branch
from
9cca766 to
9950de1
Compare
alejandro-colomar
approved these changes
Dec 9, 2025
Collaborator
alejandro-colomar
left a comment
alejandro-colomar
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Please add a Reported-by for @jubalh
ikerexxe
force-pushed
the
fix-fail-exit
branch
from
9950de1 to
c0a60d0
Compare
Collaborator
Author
|
Done |
hallyn
approved these changes
Dec 9, 2025
Member
hallyn
left a comment
hallyn
left a comment
There was a problem hiding this comment.
IMO the signatures should be the same everywhere, so I think it would be better to add MAYBE_UNUSED in the prototype and the other #ifdef branch as well. But I know alx will hate that.
I'm also fine with merging as is. Someone give me the latin phrase
for "when noone is happy, everyone is happy"
Fixes: 374ca05 (2025-10-07; "src/chsh.c: SELinux file context for fail_exit()") Reported-by: Michael Vetter <[email protected]> Signed-off-by: Iker Pedrosa <[email protected]>
ikerexxe
force-pushed
the
fix-fail-exit
branch
from
c0a60d0 to
ce8ffa3
Compare
Collaborator
Author
|
I'm going with the unnamed parameter approach. It seems like the less complex one while still maintaining a similar signature |
Collaborator
|
Thanks! I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 374ca05 (2025-10-07; "src/chsh.c: SELinux file context for fail_exit()")