-
Notifications
You must be signed in to change notification settings - Fork 255
Comparing changes
Open a pull request
base repository: shadow-maint/shadow
base: 4.17.1
head repository: shadow-maint/shadow
compare: 4.17.2
- 11 commits
- 14 files changed
- 7 contributors
Commits on Jan 7, 2025
-
src/login_nopam.c: Fix compiler warnings
The function user_match actually modifies the string passed as its first argument, so use char * instead of const char *. Signed-off-by: Tobias Stoeckmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b30e1e - Browse repository at this point
Copy the full SHA 0b30e1eView commit details -
lib/chkname.c: login_name_max_size(): Put limits for LOGIN_NAME_MAX a…
…nd sysconf(_SC_LOGIN_NAME_MAX) GNU Hurd doesn't define LOGIN_NAME_MAX. GNU Hurd recommends having no system limits. When a program needs a limit, because it needs to validate user input, it is recommended that each program defines its own limit macros. The rationale is that this avoids hard-coded limits in ABIs, which cannot be modified ever. However, that doesn't mean that programs should have no limits at all. We use this limit for validating user input, and so we shouldn't allow anything just because the system doesn't want to set a limit. So, when sysconf(2) returns -1, either due to an error or due to a claim for no limits, we must fall back to the LOGIN_NAME_MAX value. And if the system doesn't define that value, we must define it ourselves (we're more or less free to choose any value, so let's pick the one that glibc provides nowadays). Fixes: 6a1f45d (2024-02-04; "lib/chkname.c: Support unlimited user name lengths") Closes: <#1166> Cc: Chris Hofstaedtler <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Reviewed-by: Tobias Stoeckmann <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b36662 - Browse repository at this point
Copy the full SHA 8b36662View commit details -
man/: Update link to Wikipedia to use HTTPS
The link to Wikipedia's article "Password strength" was added here in 2008 and Wikipedia went HTTPS-only 7 years later. Link: <https://diff.wikimedia.org/2015/06/12/securing-wikimedia-sites-with-https/>
Configuration menu - View commit details
-
Copy full SHA for cc2ef99 - Browse repository at this point
Copy the full SHA cc2ef99View commit details
Commits on Jan 8, 2025
-
lib/attr.h: use C23 attributes only with gcc >= 10
These are not available on earlier versions and builds break there. Signed-off-by: Alexander Kanavin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 15524dd - Browse repository at this point
Copy the full SHA 15524ddView commit details -
login: Fix no-pam authorization regression
The list_match function handles EXCEPT entries through recursive calls. It calls itself with NULL, which was then passed to strtok so parsing continued at current position. Replacing strtok with strsep, this means that EXCEPT entries never match, because strsep(NULL, ...) always returns NULL, i.e. the code treats everything after EXCEPT as non-existing. Fix this by passing current list pointer to recursive call. Fixes: 90afe61 (2024-07-04; "lib/, src/: Use strsep(3) instead of strtok(3)") Signed-off-by: Tobias Stoeckmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c45b076 - Browse repository at this point
Copy the full SHA c45b076View commit details
Commits on Jan 9, 2025
-
Configuration menu - View commit details
-
Copy full SHA for bc619a8 - Browse repository at this point
Copy the full SHA bc619a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b5eb1 - Browse repository at this point
Copy the full SHA f2b5eb1View commit details
Commits on Jan 10, 2025
-
lib/: Use _exit in case of execv errors
Calling exit might trigger cleanup functions registered through atexit. Since some programs use this mechanism, be extra cautious to never release passwd/group locks too early. Reviewed-by: Alejandro Colomar <[email protected]> Signed-off-by: Tobias Stoeckmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a772484 - Browse repository at this point
Copy the full SHA a772484View commit details -
lib/: Set O_CLOEXEC for static FILE handles
With glibc we can use "e" in mode argument to set O_CLOEXEC on opened files. The /etc/shadow and /etc/gshadow file handles should be protected to make sure that they are never passed to child processes by accident. Reviewed-by: Alejandro Colomar <[email protected]> Signed-off-by: Tobias Stoeckmann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aebc4dd - Browse repository at this point
Copy the full SHA aebc4ddView commit details -
man/, po/: Update Romanian translation
Add translation of manual pages, and update the translation of strings. Bug-Debian: https://bugs.debian.org/1080487 [alx: fix typo: po => ro] Reviewed-by: Alejandro Colomar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bb4a2da - Browse repository at this point
Copy the full SHA bb4a2daView commit details
Commits on Jan 11, 2025
-
Signed-off-by: Alejandro Colomar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6a2ab3d - Browse repository at this point
Copy the full SHA 6a2ab3dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4.17.1...4.17.2