Skip to content

fix(cli): update template handling for pnpm 11#10659

Merged
shadcn merged 7 commits into
shadcn-ui:mainfrom
raashish1601:codex/10658-vite-pnpm-esbuild-builds
May 29, 2026
Merged

fix(cli): update template handling for pnpm 11#10659
shadcn merged 7 commits into
shadcn-ui:mainfrom
raashish1601:codex/10658-vite-pnpm-esbuild-builds

Conversation

@raashish1601

@raashish1601 raashish1601 commented May 15, 2026

Copy link
Copy Markdown
Contributor

Fixes #10658.

Updates pnpm workspace config for pnpm 11 build approvals and keeps non-pnpm scaffold conversion from treating single-app template config as a monorepo. Also extends the build approval config across the monorepo templates.

Validated with pnpm format:write, pnpm --filter shadcn test -- src/utils/scaffold.test.ts src/utils/get-monorepo-info.test.ts, pnpm --filter shadcn build, pnpm 11 template install smoke tests, and local CLI bun init smoke tests for Vite app and Next monorepo.

@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

@raashish1601 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

- Add packages: [] to single-app pnpm-workspace.yaml so pnpm 9 does
  not reject the file with "packages field missing or empty".
- Add astro-app, react-router-app, start-app, next-app workspace
  yamls with the build-script allowlist each template needs
  (esbuild, sharp, unrs-resolver as applicable).
- Set msw: false across all app allowlists so the registry component
  install runs cleanly under pnpm 11 without executing msw's
  service-worker postinstall.
- Add a scaffold test pinning the packages:[] + allowBuilds shape
  so the parser keeps treating it as single-app.
@shadcn shadcn added the area: roadmap This looks great. We'll add it to the roadmap, review and merge. label May 21, 2026
@vercel

vercel Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ui Ignored Ignored Preview May 29, 2026 3:01am

Request Review

@shadcn shadcn changed the title fix(cli): allow esbuild builds in Vite templates fix(cli): update template handling for pnpm 11 May 27, 2026
@shadcn
shadcn requested a review from Copilot May 27, 2026 19:27
@shadcn
shadcn merged commit 0790076 into shadcn-ui:main May 29, 2026
29 checks passed
Salloxy pushed a commit to remembertochangelater/ui that referenced this pull request May 31, 2026
* fix(cli): allow esbuild builds in Vite templates

* fix(cli): extend pnpm 11 build-script allowlists across app templates

- Add packages: [] to single-app pnpm-workspace.yaml so pnpm 9 does
  not reject the file with "packages field missing or empty".
- Add astro-app, react-router-app, start-app, next-app workspace
  yamls with the build-script allowlist each template needs
  (esbuild, sharp, unrs-resolver as applicable).
- Set msw: false across all app allowlists so the registry component
  install runs cleanly under pnpm 11 without executing msw's
  service-worker postinstall.
- Add a scaffold test pinning the packages:[] + allowBuilds shape
  so the parser keeps treating it as single-app.

* chore: changeset

* fix(templates): allow monorepo pnpm builds

* ci(templates): validate app workspace conversion

---------

Co-authored-by: shadcn <[email protected]>
aviralj02 pushed a commit to aviralj02/ui that referenced this pull request Jun 1, 2026
* fix(cli): allow esbuild builds in Vite templates

* fix(cli): extend pnpm 11 build-script allowlists across app templates

- Add packages: [] to single-app pnpm-workspace.yaml so pnpm 9 does
  not reject the file with "packages field missing or empty".
- Add astro-app, react-router-app, start-app, next-app workspace
  yamls with the build-script allowlist each template needs
  (esbuild, sharp, unrs-resolver as applicable).
- Set msw: false across all app allowlists so the registry component
  install runs cleanly under pnpm 11 without executing msw's
  service-worker postinstall.
- Add a scaffold test pinning the packages:[] + allowBuilds shape
  so the parser keeps treating it as single-app.

* chore: changeset

* fix(templates): allow monorepo pnpm builds

* ci(templates): validate app workspace conversion

---------

Co-authored-by: shadcn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: roadmap This looks great. We'll add it to the roadmap, review and merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: shadcn init fails on Vite template due to blocked esbuild build script [ERR_PNPM_IGNORED_BUILDS]

2 participants