[debug] Register #27338 EAGLE draft kv_indices revert in pr_fix_toggle#27428
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new PR revert configuration _PR_REVERT_YAML_27338 to target and edit FlashInferMultiStepDraftBackend.init_cuda_graph_state in python/sglang/srt/debug_utils/pr_fix_toggle.py, and registers it in the _PR_FIX_REVERT_YAML dictionary. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr_fix_toggleletsSGLANG_DEBUG_REVERT_PR=<n>reverse-apply a merged PR's fix for regression A/B testing. #27338 (EAGLE draft cuda-graphkv_indicestopk under-allocation) wasn't registered. This adds it: reverting drops the* self.topkfrom the buffer alloc, so the always-on size invariant #27338 added incommon_templatetrips deterministically.CI States
Latest PR Test (Base): ❌ Run #27056231459
Latest PR Test (Extra): ❌ Run #27056231414