Split the request-reception loop into smaller phases#25703
Merged
fzyzcjy merged 1 commit intoMay 19, 2026
Merged
Conversation
…ases Extract helpers from ``Scheduler.recv_requests``: - ``_pull_raw_reqs``: pull raw incoming requests off the IPC PULL socket - ``_broadcast_reqs_across_ranks``: replicate the pulled list across ranks - ``_apply_mm_receiver``: run the optional multimodal receiver on each req - ``_finalize_shm_features``: finalize SHM-backed fields once reqs have been broadcast and accepted Each extracted helper preserves the original body byte-equivalent and is placed in call order below ``recv_requests``. No behavior change. Refactor chain ID: extract-recv-requests-helpers
fzyzcjy
requested review from
Ying1123,
hnyls2002,
merrymercy and
xiezhq-hermann
as code owners
May 19, 2026 01:11
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
deleted the
tom/pr_chain/tom_refactor_202605a/primary/nonmech_scheduler/split-recv-requests
branch
May 19, 2026 01:12
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract helpers from
Scheduler.recv_requests:_pull_raw_reqs: pull raw incoming requests off the IPC PULL socket_broadcast_reqs_across_ranks: replicate the pulled list across ranks_apply_mm_receiver: run the optional multimodal receiver on each req_finalize_shm_features: finalize SHM-backed fields once reqs havebeen broadcast and accepted
Each extracted helper preserves the original body byte-equivalent and is
placed in call order below
recv_requests. No behavior change.Refactor chain ID: extract-recv-requests-helpers
CI States
Latest PR Test (Base): ❌ Run #26070013417
Latest PR Test (Extra): ❌ Blocked --
run-ciis required first.