[Doc] correct the HTTP endpoint for stopping profiling in benchmark_and_profiling.md#22523
Merged
Conversation
github-actions
Bot
added
the
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the developer documentation to rename the profiling termination endpoint from /end_profile to /stop_profile across several examples and descriptions. A review comment correctly identifies a discrepancy where the documentation describes a start_step parameter that is currently unsupported in the backend implementation, which could lead to user confusion.
b8zhong
approved these changes
Apr 16, 2026
Collaborator
|
Thanks. |
jmamou
pushed a commit
to jmamou/sglang
that referenced
this pull request
Apr 20, 2026
caitengwei
pushed a commit
to caitengwei/sglang
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
Doc fix: correct the HTTP endpoint for stopping profiling in
developer_guide/benchmark_and_profiling.mdto/stop_profileReview and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ci