Skip to content

chore(hack): add script to generate manifests.yaml#95

Merged
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:chore/add-script-to-generate-manifest
Nov 11, 2025
Merged

chore(hack): add script to generate manifests.yaml#95
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:chore/add-script-to-generate-manifest

Conversation

@Syspretor
Copy link
Copy Markdown
Collaborator

@Syspretor Syspretor commented Nov 11, 2025

Ⅰ. Motivation

Currently, during releases we only update the Helm content, and the manifest.yaml used by kubectl is not updated. This PR support to generate the manifest from the Helm chart to keep the release manifest.yaml in sync.

  1. Rename $RBG_HOME/tools/release/version-update.sh to $RBG_HOME/tools/release/update-release.sh
  2. Add codes to generate the manifest from the Helm chart

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@Syspretor Syspretor requested a review from cheyang November 11, 2025 11:50
@Syspretor Syspretor changed the title chore(hack): add script to generate manifests.yaml [WIP] chore(hack): add script to generate manifests.yaml Nov 11, 2025
@Syspretor Syspretor force-pushed the chore/add-script-to-generate-manifest branch from 32c28eb to b842826 Compare November 11, 2025 11:52
@Syspretor Syspretor changed the title [WIP] chore(hack): add script to generate manifests.yaml chore(hack): add script to generate manifests.yaml Nov 11, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread hack/deploy/generate-kubectl-manifests.sh Outdated
@Syspretor Syspretor force-pushed the chore/add-script-to-generate-manifest branch from b842826 to 2803012 Compare November 11, 2025 12:15
@Syspretor Syspretor force-pushed the chore/add-script-to-generate-manifest branch from 2803012 to 5edf645 Compare November 11, 2025 12:42
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit 7e93ff7 into sgl-project:main Nov 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants