fix(sts-reconciler): use compatible headless service name for statefu…#81
Merged
cheyang merged 1 commit intosgl-project:mainfrom Oct 30, 2025
Merged
Conversation
…lsets - Update StatefulSet reconciliation to use a compatible headless service name - Add error handling for cases where a compatible service name cannot be found - This change ensures compatibility with headless services in various environments Signed-off-by: trafalgarzzz <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the StatefulSet service name configuration to use a compatible headless service name instead of the workload name. This ensures consistency across the codebase for service naming, particularly when services need to comply with DNS naming conventions.
- Uses
GetCompatibleHeadlessServiceNameto determine the correct service name for StatefulSet configuration - Replaces hardcoded
rbg.GetWorkloadName(role)with the dynamically determinedsvcName
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| WithSpec( | ||
| appsapplyv1.StatefulSetSpec(). | ||
| WithServiceName(rbg.GetWorkloadName(role)). | ||
| // WithServiceName(rbg.GetWorkloadName(role)). |
There was a problem hiding this comment.
Remove the commented-out code. Commented-out code should not be left in production as it reduces code clarity and can cause confusion.
Suggested change
| // WithServiceName(rbg.GetWorkloadName(role)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #80
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.