feat: add instanceset api#50
Merged
cheyang merged 1 commit intosgl-project:mainfrom Oct 11, 2025
Merged
Conversation
Contributor
Author
|
/cc @cheyang |
cheyang
reviewed
Oct 10, 2025
cheyang
reviewed
Oct 10, 2025
| // InPlaceIfPossibleInstanceSetUpdateStrategyType indicates that we try to in-place update Instances instead of | ||
| // recreating Instances when possible. Currently, only image update of Instances spec is allowed. Any other changes to the Instances | ||
| // spec will fall back to ReCreate InstanceSetUpdateStrategyType where Instances will be recreated. | ||
| InPlaceIfPossibleInstanceSetUpdateStrategyType InstanceSetUpdateStrategyType = "InPlaceIfPossible" |
Collaborator
There was a problem hiding this comment.
How about InPlaceIfPossible also indicates the instance will be recreated on the same node?
Contributor
Author
There was a problem hiding this comment.
How about InPlaceIfPossible also indicates the instance will be recreated on the same node?
@cheyang InPlaceIfPossible indicates that, unless the component size changes, the Instance object will be updated in-place instead of being recreated. In this case, the Pods owned by this Instance will also be upgraded in-place as much as possible.
Signed-off-by: veophi <[email protected]>
veophi
force-pushed
the
api/instanceset
branch
from
561e618 to
d791181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Introduce a new worklad -- InstanceSet.
More information see the KEP #26
Ⅱ. Modifications
Add Instance&InstanceSet APIs&CRDs.
Ⅲ. Does this pull request fix one issue?
fixes #45
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.