Skip to content

bugfix: Added consistency check for probes#29

Merged
cheyang merged 1 commit intosgl-project:mainfrom
bcfre:dev
Sep 19, 2025
Merged

bugfix: Added consistency check for probes#29
cheyang merged 1 commit intosgl-project:mainfrom
bcfre:dev

Conversation

@bcfre
Copy link
Copy Markdown
Collaborator

@bcfre bcfre commented Sep 18, 2025

Ⅰ. Motivation

Added consistency check for probes

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #21

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Sep 18, 2025

@bcfre Please fix the conflict issue.

@bcfre
Copy link
Copy Markdown
Collaborator Author

bcfre commented Sep 18, 2025

@bcfre Please fix the conflict issue.

@cheyang done

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit 37e36f9 into sgl-project:main Sep 19, 2025
3 checks passed
@bcfre bcfre deleted the dev branch December 3, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] How to change the unit scale of P or D at the RGB layer, given that the P/D scale of LWS becomes unmodifiable once it is determined?

2 participants