feat(cli): enhance llm svc run with two new override flags#289
Merged
Syspretor merged 5 commits intosgl-project:mainfrom Apr 22, 2026
Merged
feat(cli): enhance llm svc run with two new override flags#289Syspretor merged 5 commits intosgl-project:mainfrom
Syspretor merged 5 commits intosgl-project:mainfrom
Conversation
diw-zw
changed the title
diw-zw
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CLI documentation and refactors the storage plugin interface to use a centralized DefaultMountPath instead of per-plugin methods. It introduces new flags for the svc run command, including --image and --model-path, and updates the benchmark commands for better consistency. Review feedback focuses on ensuring cross-platform path compatibility by using filepath.ToSlash for paths intended for use inside Linux containers, preventing issues when the CLI is run on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance
llm svc runwith two new override flags and moveMountPathfrom the storage plugin interface intoMountOptions, plus a comprehensive README audit.Changes
1. New
--model-pathflag inllm svc runUsers who place models directly into storage (bypassing
llm model pull) can now specify the exact container path. Without this flag the default/models/<model>/<revision>path is used.2. New
--imageflag inllm svc runAllows overriding the container image from the mode config. Useful when the default image registry is inaccessible (e.g. DockerHub in China) and a mirror registry is needed.
3. Move
MountPathfromPlugin.MountPath()toMountOptions.MountPathPlugin.MountPath()method removed from the interface — mount path is no longer a plugin-level concern.DefaultMountPath = "/models"constant added tointerface.go.MountOptions.MountPathfield introduced; all callers passstorageplugin.DefaultMountPath.OSSStorageandPVCStorageimplementations updated to readopts.MountPath.MountPath()test cases removed;MountStoragecalls updated to includeMountPath: DefaultMountPath.4. README.md audit and fixes
svc run: Added--image,--model-path,--wait,--wait-timeout,--test-api,--test-api-timeout,--local-portflags.svc list: Removed global--namespace(inherited from root).svc delete: Changed usage toNAME...(supports multiple args); removed global-only Flags table.svc chat: Fixed interactive example (-irequired); fixed--systemexample.model pull: Added--revision,--waitflags.model list: Corrected--storage(was--source).benchmark get/delete/logs: Added--jobflag;benchmark logsusage fixed fromJOB_NAMEtoRBG_NAMEwith--joband--followflags.config add-storage: Added--configflag; fixed example keys.MODEL_NAME→MODEL_ID.