[KEP-31]: Adding ControllerRevision support to the RoleBasedGroup#27
Merged
cheyang merged 3 commits intosgl-project:mainfrom Oct 30, 2025
Merged
[KEP-31]: Adding ControllerRevision support to the RoleBasedGroup#27cheyang merged 3 commits intosgl-project:mainfrom
cheyang merged 3 commits intosgl-project:mainfrom
Conversation
bcfre
changed the title
bcfre
changed the title
bcfre
force-pushed
the
controllerrevision
branch
2 times, most recently
from
7bd3142 to
ba9745c
Compare
Signed-off-by: 柏存 <[email protected]>
bcfre
force-pushed
the
controllerrevision
branch
from
ba9745c to
536d807
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a KEP (Kubernetes Enhancement Proposal) for adding ControllerRevision support to the RoleBasedGroup (RBG) object, enabling historical state tracking and version awareness for RBG configurations.
Key Changes:
- Proposes using Kubernetes ControllerRevision resources to store historical RBG states
- Introduces per-role revision tracking to prevent unintended cross-role updates
- Maintains backward compatibility with existing semantic equality-based update mechanisms
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| keps/31-rbg-controller-revision/kep.yaml | Metadata file defining the KEP proposal including authorship, status, and milestone information |
| keps/31-rbg-controller-revision/README.md | Detailed KEP documentation explaining motivation, design, API changes, and implementation approach for ControllerRevision support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: bcfre <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
KEP: adding ControllerRevision support to the RoleBasedGroup (RBG) object to store its historical states.
Ⅱ. Modifications
kep proposal
Ⅲ. Does this pull request fix one issue?
fixes #21
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.