fix(rbgsa-controller): use Warning event type for failure events#262
Merged
Syspretor merged 1 commit intosgl-project:mainfrom Apr 10, 2026
Merged
fix(rbgsa-controller): use Warning event type for failure events#262Syspretor merged 1 commit intosgl-project:mainfrom
Syspretor merged 1 commit intosgl-project:mainfrom
Conversation
FailedGetRBGRole and FailedScale events were emitted as EventTypeNormal, making them invisible to standard alerting that filters on Warning events. Also fix logger.Error calls that used printf-style %s format verbs instead of structured key-value pairs, which produced malformed log entries.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FailedGetRBGRoleandFailedScaleevents fromEventTypeNormaltoEventTypeWarning— failure events should use Warning per K8s conventionslogger.Errorcalls that used printf-style%sformat verbs instead of structured key-value pairs, which produced malformed log entries with literal%sin the messageTest plan
go test ./internal/controller/workloads/passesgo vet ./internal/controller/workloads/clean