chore: use ARCH and remove TARGETARCH fallback#256
Merged
cheyang merged 1 commit intosgl-project:mainfrom Apr 1, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the Dockerfile for the crd-upgrade tool to change how the TARGETARCH argument is handled during the kubectl installation. The review feedback identifies a contradiction between the PR's stated goal and the implementation, which still includes a default fallback to amd64 via shell expansion, and suggests using the TARGETARCH variable directly for more idiomatic Dockerfile code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Remove the default value from
ARG TARGETARCHto align withdocker buildxbest practices. Buildx automatically injects the correct architecture during multi-arch builds, making a static default unnecessary and potentially conflicting.To maintain compatibility for users running plain
docker build .(which does not passTARGETARCH), we now use a shell parameter expansion fallback:ARCH="${TARGETARCH:-amd64}". All subsequent steps reference${ARCH}instead. This ensures reliable builds across bothbuildxworkflows and standarddocker buildcommands.Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
Build an arm image and run. Check whether kubectl works fine.
VI. Special notes for reviews
Checklist
make fmt.