Enhance service reconciler#252
Merged
Syspretor merged 1 commit intosgl-project:mainfrom Apr 10, 2026
Merged
Conversation
Signed-off-by: lx1036 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ServiceReconciler to use typed constants for the service configuration, explicitly setting the service type to ClusterIP and replacing the hardcoded string "None" with corev1.ClusterIPNone. I have no feedback to provide.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the headless Service apply configuration constructed by the service reconciler to be more explicit and type-safe when setting ServiceSpec fields.
Changes:
- Explicitly sets
spec.typetoClusterIPwhen constructing the headless Service. - Replaces the literal
"None"ClusterIP value with the typed constantcorev1.ClusterIPNone.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@lx1036 Sorry for the delay in handling this issue, and thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance service reconciler