fix(port-allocator): add startup args to charts#249
Merged
Syspretor merged 1 commit intosgl-project:mainfrom Mar 27, 2026
Merged
fix(port-allocator): add startup args to charts#249Syspretor merged 1 commit intosgl-project:mainfrom
Syspretor merged 1 commit intosgl-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces port allocation configuration to the manager deployment by adding command-line arguments for strategy, start port, and port range in the Helm templates, along with corresponding default values. A review comment suggests enhancing the template's robustness by using a conditional block to handle scenarios where the portAllocator configuration might be missing from the user-provided values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Add Helm configuration support for port allocator parameters to allow users customize port allocation strategy and range without modifying templates directly.
Ⅱ. Modifications
manager.yaml: Updated to read port allocator config from.Values.portAllocatorwith defaultsvalues.yaml: AddedportAllocatorsection withstrategy,startPort, andportRangeoptionsDefault values (backward compatible):
random300005000Ⅲ. Does this pull request fix one issue?
NONE
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.