chore: add check for yaml lint#238
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces YAML linting to the project. By adding a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a .yamllint.yml configuration file to enforce consistent styling for YAML files within the repository. The configuration correctly extends the default rules and ignores generated CRD files. I have provided a couple of suggestions to improve the consistency of the linting rules themselves, which will enhance the maintainability of your YAML files.
Syspretor
force-pushed
the
ch0re/add-check-for-yaml-lint
branch
2 times, most recently
from
c1b5e77 to
8349b3c
Compare
Syspretor
force-pushed
the
ch0re/add-check-for-yaml-lint
branch
from
8349b3c to
b65f498
Compare
|
|
||
| - name: YAML lint check | ||
| run: | | ||
| pip install yamllint |
There was a problem hiding this comment.
Non-blocking thought: it may be worth pinning the yamllint version here. Installing the latest version keeps setup simple, but it can also make CI behavior drift over time if lint rules change upstream.
2 participants
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.