fix(rbgs): missing re-generate client code for rbgs#236
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request rectifies an oversight in the client code generation for RoleBasedGroupSets by eliminating an erroneously generated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the auto-generated client-go apply configurations to match the recent refactoring of the RoleBasedGroupSet API. The changes correctly replace the now-defunct RoleBasedGroupTemplateSpec with RoleBasedGroupSpec in the RoleBasedGroupSetSpecApplyConfiguration, remove the obsolete generated files, and update the utility functions. These modifications are consistent and necessary to align the client code with the API definition.
There was a problem hiding this comment.
Pull request overview
Regenerates/fixes the client-go apply-configuration output for workloads/v1alpha1 so it matches the actual v1alpha1 API shape (RBGS uses template, not groupTemplate), removing stale generated types and mappings.
Changes:
- Removes the v1alpha1 apply-configuration for
RoleBasedGroupTemplateSpec(type does not exist in v1alpha1 API). - Updates
RoleBasedGroupSetSpecApplyConfiguration(v1alpha1) to useTemplatewith the correct JSON tag and builder method. - Drops the v1alpha1
ForKindmapping forRoleBasedGroupTemplateSpecin apply-configuration utilities.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client-go/applyconfiguration/workloads/v1alpha1/rolebasedgrouptemplatespec.go | Removes stale v1alpha1 generated apply-config type for a non-existent API kind. |
| client-go/applyconfiguration/workloads/v1alpha1/rolebasedgroupsetspec.go | Aligns v1alpha1 RBGS spec apply-config to Template (and WithTemplate) instead of GroupTemplate. |
| client-go/applyconfiguration/utils.go | Removes v1alpha1 ForKind case for RoleBasedGroupTemplateSpec while keeping v1alpha2 support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.