Controllerrevisions default#234
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a default value for RevisionHistoryLimit in RoleInstanceSet to prevent an excessive number of stale controller revisions. The changes correctly add a default of 10 at the API level via kubebuilder markers and update the controller logic to apply this default for existing resources that may not have this field set. The CRD is also updated accordingly. My feedback includes a suggestion to use a constant for the default value to improve maintainability.
JasonHe-WQ
changed the title
JasonHe-WQ
force-pushed
the
controllerrevisions-default
branch
from
455afe9 to
898c82d
Compare
JasonHe-WQ
changed the title
JasonHe-WQ
force-pushed
the
controllerrevisions-default
branch
from
898c82d to
78b98b0
Compare
There was a problem hiding this comment.
Pull request overview
Fixes RoleInstanceSet controller revision history truncation when spec.revisionHistoryLimit is omitted (stateful mode), and factors the truncation logic into a shared utility to keep both stateful/stateless implementations consistent.
Changes:
- Add
DefaultRoleInstanceSetRevisionHistoryLimit(10) and apply it in stateful/stateless truncation paths when the field is nil. - Introduce
pkg/utils/history.TruncateControllerRevisionsand refactor both reconcilers to use it. - Add CRD/API defaulting + minimum validation for
revisionHistoryLimit, plus targeted unit tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/utils/history/truncate_history.go |
New shared helper to delete oldest non-live ControllerRevisions up to a limit. |
pkg/utils/history/truncate_history_test.go |
Unit tests for the new truncation helper behavior. |
pkg/reconciler/roleinstanceset/statefulmode/stateful_instance_set_control.go |
Fix stateful truncation to apply default limit when nil; use shared helper. |
pkg/reconciler/roleinstanceset/statefulmode/stateful_instance_set_control_test.go |
Adds a unit test around truncation behavior in stateful mode. |
pkg/reconciler/roleinstanceset/statelessmode/reconciler.go |
Refactor stateless truncation to use shared helper + shared default constant. |
pkg/reconciler/roleinstanceset/statelessmode/reconciler_test.go |
Adds a unit test ensuring live short-hash revisions aren’t deleted. |
api/workloads/v1alpha2/roleinstanceset_types.go |
Adds default/validation markers and introduces the default history limit constant. |
config/crd/bases/workloads.x-k8s.io_roleinstancesets.yaml |
CRD schema updated with default: 10 and minimum: 0 for revisionHistoryLimit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks good. It’d be nice to add a regression test for the |
Ⅰ. Motivation
Ⅱ. Modifications
fix default controller revisions limit in stateful pattern to avert too many stale revisions and generalize truncate history function
Ⅲ. Does this pull request fix one issue?
fixes #227
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.