feat(scheduler): inherit podGroup annotations#233
Merged
Syspretor merged 4 commits intosgl-project:mainfrom Mar 26, 2026
Merged
feat(scheduler): inherit podGroup annotations#233Syspretor merged 4 commits intosgl-project:mainfrom
Syspretor merged 4 commits intosgl-project:mainfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
JasonHe-WQ
force-pushed
the
feat/podgroup-annotation
branch
from
c5978f0 to
a7522e0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Volcano PodGroup manager to propagate Volcano-scoped annotations (those prefixed with volcano.sh/) from a RoleBasedGroup onto the corresponding Volcano PodGroup, aligning behavior with other controllers.
Changes:
- Add logic to collect and set
volcano.sh/*annotations from the RBG onto the Volcano PodGroup metadata. - Introduce a small helper (
inheritVolcanoAnnotations) to filter annotations by prefix. - Add a unit test validating that Volcano-prefixed annotations are copied on PodGroup creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/scheduler/volcano/manager.go | Copies Volcano-prefixed annotations from RBG into the created Volcano PodGroup and adds a helper for filtering. |
| pkg/scheduler/podgroup_manager_test.go | Adds a test ensuring Volcano-prefixed annotations are copied to PodGroup annotations on create. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JasonHe-WQ
force-pushed
the
feat/podgroup-annotation
branch
2 times, most recently
from
06bd30b to
afd4765
Compare
JasonHe-WQ
force-pushed
the
feat/podgroup-annotation
branch
from
afd4765 to
c79c256
Compare
cheyang
reviewed
Mar 23, 2026
cheyang
reviewed
Mar 23, 2026
cheyang
reviewed
Mar 23, 2026
JasonHe-WQ
changed the title
JasonHe-WQ
changed the title
JasonHe-WQ
changed the title
JasonHe-WQ
force-pushed
the
feat/podgroup-annotation
branch
from
ca97a6f to
052b7be
Compare
JasonHe-WQ
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JasonHe-WQ
force-pushed
the
feat/podgroup-annotation
branch
from
b86d4d8 to
53ed71f
Compare
Syspretor
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
align with
lwscontrollers' behaviourⅡ. Modifications
coped annotations with
volcanoprefix fromrbgtopod groupⅢ. Does this pull request fix one issue?
impl #232
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
For some annotations, it may be covered by volcano scheduler when scheduled, e.g.volcano.sh/job-allocated-hypernode.Therefore, we may need to use another map to store these annotations.Or we can simplify the impl to only support copy from
rbgwhen create and ignore update.We don't update annos on
podgroupwhen updaterbgsince some update may break scheduling policy and hard to investigateChecklist
make fmt.