Skip to content

chore: add copyright 2026#229

Merged
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:chore/add-copyright-2026
Mar 21, 2026
Merged

chore: add copyright 2026#229
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:chore/add-copyright-2026

Conversation

@Syspretor
Copy link
Copy Markdown
Collaborator

Ⅰ. Motivation

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@Syspretor Syspretor requested a review from cheyang March 20, 2026 09:29
@Syspretor Syspretor force-pushed the chore/add-copyright-2026 branch from 27183d1 to 18eca7c Compare March 20, 2026 09:32
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on adding a standardized copyright header to all Go files within the repository. This ensures that the project's licensing and copyright information is clearly and consistently stated across the codebase. The changes are purely additive and do not impact the functionality of the code.

Highlights

  • Copyright Update: This pull request adds a copyright notice for the year 2026 to the top of numerous Go source files.
  • Licensing: The copyright notice includes a license under the Apache License, Version 2.0, specifying terms for use, modification, and distribution of the software.
  • Code Compliance: The addition of the copyright aims to ensure compliance with open-source licensing standards and to protect the rights of the RBG Authors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds copyright headers to a large number of files. However, a change in one of the test files introduces a syntax error that will break the build. Please see the comment for details.

I am having trouble creating individual review comments. Click here to see my feedback.

pkg/inplace/pod/inplaceupdate/inplace_update_test.go (430-432)

critical

This change introduces a syntax error. In Go, string literals defined with double quotes cannot span multiple lines. The original implementation using \n for newlines was correct. Please revert this change to fix the test compilation.

			t.Fatalf("case %s failed, expected \n%v got \n%v", testCase.name, util.DumpJSON(testCase.expectedPod), util.DumpJSON(got))

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit 6114db1 into sgl-project:main Mar 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants