Skip to content

fix(rbg): fix rbg delete failed in foreground deletion#219

Merged
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:fix/rbg-delete-hang
Mar 18, 2026
Merged

fix(rbg): fix rbg delete failed in foreground deletion#219
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:fix/rbg-delete-hang

Conversation

@Syspretor
Copy link
Copy Markdown
Collaborator

@Syspretor Syspretor commented Mar 17, 2026

Ⅰ. Motivation

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist Bot commented Mar 17, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where StorageError could occur during the foreground deletion of RoleInstance and RoleInstanceSet objects. The changes introduce robust checks within the reconciliation and status update logic to gracefully handle objects that are in the process of being deleted, thereby preventing errors caused by an empty UID during deletion.

Highlights

  • RoleInstance Reconciliation: Implemented a check to skip reconciliation for RoleInstance objects that are in the process of being deleted, preventing potential StorageError during foreground deletion.
  • Stateful RoleInstanceSet Status Updates: Added logic to prevent status updates for RoleInstanceSet objects in stateful mode if they are marked for deletion, addressing StorageError issues. This check is performed both initially and after fetching the object from the lister.
  • Stateless RoleInstanceSet Status Updates: Introduced a similar check to skip status updates for RoleInstanceSet objects in stateless mode when they are being deleted. Additionally, switched from Update to Patch for status updates to ensure only the status field is modified, avoiding conflicts with concurrent changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pkg/reconciler/roleinstance/instance_reconciler.go
    • Added a check to skip reconciliation if the RoleInstance is being deleted.
  • pkg/reconciler/roleinstanceset/statefulmode/stateful_instance_set_status_updater.go
    • Implemented a check to skip status updates if the RoleInstanceSet is being deleted.
    • Added a re-check for deletion timestamp after refreshing the object from the lister.
  • pkg/reconciler/roleinstanceset/statelessmode/status.go
    • Imported apierrors for error handling.
    • Added a check to skip status updates if the RoleInstanceSet is being deleted.
    • Included a re-check for deletion timestamp after fetching the object from the API server.
    • Changed the status update mechanism from Update to Patch to prevent overwriting concurrent changes.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the issue of foreground deletion failures by introducing checks for DeletionTimestamp in the reconcilers. The changes are logical and follow standard Kubernetes controller patterns. Additionally, the switch from Update to Patch for status updates in statelessmode is a welcome improvement, enhancing robustness and fixing a subtle bug related to annotation handling. I have one suggestion to further improve the code by addressing the use of context.TODO().

Comment thread pkg/reconciler/roleinstanceset/statelessmode/status.go
cheyang
cheyang approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

cheyang
cheyang approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit 623fbe4 into sgl-project:main Mar 18, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Syspretor @cheyang