chore(role-instanceset): change spec podManagement field type#207
Merged
cheyang merged 1 commit intosgl-project:mainfrom Mar 16, 2026
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the v1alpha2 API types to use constants.PodManagementPolicyType directly for podManagementPolicy, removing the local v1alpha2 alias/forwarded constants.
Changes:
- Removed the v1alpha2
PodManagementPolicyTypetype alias and related forwarded constants fromroleinstanceset_types.go. - Updated
PodManagementPolicyfields in RoleInstanceSet and RoleSpec to useconstants.PodManagementPolicyTypedirectly. - Added the
pkg/constantsimport torolebasedgroup_types.go.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api/workloads/v1alpha2/roleinstanceset_types.go | Removes the v1alpha2 alias/forwarders and switches the spec field to constants.PodManagementPolicyType. |
| api/workloads/v1alpha2/rolebasedgroup_types.go | Updates RoleSpec’s PodManagementPolicy field type and adds the needed import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
26
to
31
| const ( | ||
| DefaultRoleInstanceSetMaxUnavailable = "10%" | ||
| ) | ||
|
|
||
| // PodManagementPolicyType is an alias for constants.PodManagementPolicyType. | ||
| type PodManagementPolicyType = constants.PodManagementPolicyType | ||
|
|
||
| const ( | ||
| OrderedReadyPodManagement = constants.OrderedReadyPodManagement | ||
| ParallelPodManagement = constants.ParallelPodManagement | ||
| ) | ||
|
|
||
| // RoleInstanceSetSpec defines the desired state of RoleInstanceSet | ||
| type RoleInstanceSetSpec struct { |
cheyang
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.