feat: Format action templates to match sglang's pattern#19
Merged
cheyang merged 1 commit intosgl-project:mainfrom Sep 5, 2025
Merged
feat: Format action templates to match sglang's pattern#19cheyang merged 1 commit intosgl-project:mainfrom
cheyang merged 1 commit intosgl-project:mainfrom
Conversation
Collaborator
|
@Pikabooboo Thanks for your contribution. I suggest renaming TEMPLATES to ISSUE_TEMPLATE and keeping the pull request template separate at .github/pull_request_template.md to follow GitHub's standard conventions. Just follow the convention of https://github.com/sgl-project/sglang/tree/main/.github. |
Signed-off-by: pikabooboo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Format action templates to match sglang's repo
Ⅱ. Modifications
Added ISSUE_TEMPLATE folder and created bug-report / feature request template.
Ⅲ. Does this pull request fix one issue?
NONE
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.