refactor(rbg): add api v1alpha2#167
Merged
cheyang merged 2 commits intosgl-project:mainfrom Mar 2, 2026
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
79d8714 to
0c09c46
Compare
0c09c46 to
7f97d47
Compare
cheyang
reviewed
Mar 2, 2026
cheyang
reviewed
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #166 Phase 1: Add RoleBasedGroup apiVersion v1alpha2
Ⅰ. Motivation
Ⅱ. Modifications
Phase 1: Add RoleBasedGroup apiVersion v1alpha2
1.1 Deprecate Workload Field
Goal: Simplify API by removing the burden of explicitly specifying workload type
workloadfield as deprecated1.2 Change Default Workload Type to InstanceSet
Goal: InstanceSet as the default and recommended workload type
1.3 Redefine Role Template Declaration for Standalone/Multi-node Topology
Goal: Use Pattern model to clearly distinguish standalone and multi-node deployment
Completed Work:
Patternstructure withstandalonePatternandleaderWorkerPatternTemplateSourceencapsulatestemplateandtemplateRefTemplateRefencapsulatesnameandpatchfieldstemplate,templateRef,templatePatchfields from RoleSpecleaderWorkerSetfield, replaced byleaderWorkerPatternv1alpha2 RoleSpec New Structure:
1.4 Temporarily Remove PodGroupPolicy / CoordinationRequirements Fields
Goal: Decouple gang scheduling and coordination into independent CRDs
podGroupPolicyfield from v1alpha2RoleBasedGroupSpeccoordinationfield from v1alpha2RoleBasedGroupSpec1.5 Use v1alpha1 as Storage Version
Goal: Ensure backward compatibility and smooth transition
+kubebuilder:storageversionⅢ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.