feat(cli): update benchmark cli#157
Merged
cheyang merged 5 commits intosgl-project:mainfrom Feb 13, 2026
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Pull Request Test Coverage Report for Build 21932263741Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the kubectl rbg llm benchmark CLI to improve UX around inspecting benchmark jobs/config, align PVC URI handling, and support building/publishing the benchmark dashboard image.
Changes:
- Added
benchmark getto fetch and display the benchmark config stored on a Job annotation. - Simplified PVC URI parsing by removing
{namespace}:{pvc}support and documenting namespace resolution via kubeconfig context. - Improved operational behavior for logs/dashboard (pod readiness handling, port-forward error propagation, cleanup context) and updated docs/workflow.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
doc/features/kubectl-rbg-benchmark.md |
Documents the new get command and updated PVC URI format; updates flag defaults and examples. |
cmd/cli/cmd/llm/benchmark/pvc_test.go |
Removes namespace-in-URI test cases to match new PVC parsing rules. |
cmd/cli/cmd/llm/benchmark/pvc.go |
Drops namespace parsing from PVC URIs and updates parsing logic/docs. |
cmd/cli/cmd/llm/benchmark/logs.go |
Adjusts pod readiness waiting to allow log streaming from terminated pods. |
cmd/cli/cmd/llm/benchmark/job.go |
Stores serialized benchmark config on the Job via annotation for later retrieval. |
cmd/cli/cmd/llm/benchmark/get.go |
New command to read the Job annotation config and print it as YAML. |
cmd/cli/cmd/llm/benchmark/dashboard_portforward.go |
Propagates port-forward process exit errors via result channel. |
cmd/cli/cmd/llm/benchmark/dashboard_pod_test.go |
Removes dashboard PVC namespace test now that PVC namespace is no longer represented in parsed components. |
cmd/cli/cmd/llm/benchmark/dashboard_cmd.go |
Uses a timeout context for pod deletion and updates pod readiness call signature. |
cmd/cli/cmd/llm/benchmark/benchmark.go |
Registers the new get subcommand and enforces --config/-f mutual exclusivity; updates defaults/docs for flags. |
.github/workflows/docker-build-push.yml |
Adds build/push step and summary entry for the benchmark dashboard image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cheyang
requested changes
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
/gemini review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.